Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM]test(ticdc): introduce new testkit to make writing unit test easier #10144

Closed
wants to merge 11 commits into from
Closed

[DNM]test(ticdc): introduce new testkit to make writing unit test easier #10144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
150db5c
add testkit.
3AceShowHand Nov 23, 2023
dcfea51
fix mounter unit test.
3AceShowHand Nov 23, 2023
8a9d441
update testkit.
3AceShowHand Nov 23, 2023
d58e944
update testkit.
3AceShowHand Nov 23, 2023
62eacce
testkit support dml to event.
3AceShowHand Nov 23, 2023
d07a9c1
fix some test.
3AceShowHand Nov 23, 2023
d69d582
fix some test.
3AceShowHand Nov 23, 2023
d4a04e8
fix some tests.
3AceShowHand Nov 23, 2023
5833505
fix ut
3AceShowHand Nov 27, 2023
8bce06c
fix mounter test
3AceShowHand Nov 27, 2023
e678896
fix test.
3AceShowHand Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cdc/api/v2/api_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ import (
func TestVerifyCreateChangefeedConfig(t *testing.T) {
ctx := context.Background()
pdClient := &mockPDClient{}
helper := entry.NewSchemaTestHelper(t)
helper.Tk().MustExec("use test;")
storage := helper.Storage()
tk := entry.NewTestKit(t, config.GetDefaultReplicaConfig())
tk.MustExec("use test;")
storage := tk.Storage()
ctrl := mock_controller.NewMockController(gomock.NewController(t))
cfg := &ChangefeedConfig{}
h := &APIV2HelpersImpl{}
Expand Down Expand Up @@ -112,9 +112,9 @@ func TestVerifyUpdateChangefeedConfig(t *testing.T) {
Config: config.GetDefaultReplicaConfig(),
}
oldUpInfo := &model.UpstreamInfo{}
helper := entry.NewSchemaTestHelper(t)
helper.Tk().MustExec("use test;")
storage := helper.Storage()
tk := entry.NewTestKit(t, config.GetDefaultReplicaConfig())
tk.MustExec("use test;")
storage := tk.Storage()
h := &APIV2HelpersImpl{}
newCfInfo, newUpInfo, err := h.verifyUpdateChangefeedConfig(ctx, cfg, oldInfo, oldUpInfo, storage, 0)
require.NotNil(t, err)
Expand Down
Loading
Loading