Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudstorage(ticdc): Remove nfs schema file check (#10138) #10154

Merged
merged 3 commits into from
Nov 24, 2023
Merged

cloudstorage(ticdc): Remove nfs schema file check (#10138) #10154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db3d86
remove nfs tmp schema file checking
sdojjy Nov 23, 2023
f4099ec
update comment
sdojjy Nov 23, 2023
bb69168
address comment
sdojjy Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/sink/cloudstorage/path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,17 +221,17 @@ func (f *FilePathGenerator) CheckOrWriteSchema(
// Case 2: the table meta path is not empty.
if schemaFileCnt != 0 {
if lastVersion == 0 {
log.Panic("no table schema file found in an non-empty meta path",
log.Warn("no table schema file found in an non-empty meta path",
zap.Any("versionedTableName", table),
zap.Uint32("checksum", checksum))
}
f.versionMap[table] = lastVersion
return nil
}

// Case 3: the table meta path is empty, which only happens when the table is
// existed before changefeed started. We need to write schema file to external
// storage.
// Case 3: the table meta path is empty, which happens when:
// a. the table is existed before changefeed started. We need to write schema file to external storage.
// b. the schema file is deleted by the consumer. We write schema file to external storage too.
encodedDetail, err := def.MarshalWithQuery()
if err != nil {
return err
Expand Down
Loading