Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): cleanup expired files by day for storage sink (#10097) #10163

Merged
merged 10 commits into from
Feb 7, 2024
Merged

sink(ticdc): cleanup expired files by day for storage sink (#10097) #10163

merged 10 commits into from
Feb 7, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10097

What problem does this PR solve?

Issue Number: close #10109

What is changed and how it works?

Add two parameters to control the cleaning behavior of expired files, for example:

  1. To keep one day's files and clean them at 18 o 'clock every day, users can use the following configuration.
[sink.cloud-storage-config]
file-expiration-days = 1
# Second | Minute | Hour | Dom | Month | DowOptional
file-cleanup-cron-spec = "0 18 * * * *"
  1. To keep files for a week and clean them every Monday at 2 am, you can use the following configuration.
[sink.cloud-storage-config]
file-expiration-days = 7
# Second | Minute | Hour | Dom | Month | DowOptional
file-cleanup-cron-spec = "0 2 * * * 1"
  1. The default configuration is
[sink.cloud-storage-config]
file-expiration-days = 0 # The default congiuration
file-cleanup-cron-spec = "0 2 * * * *"
  • By default, files are not cleaned.
  • If only the file-expiration-days is configured, then by default cdc will clean files at 2 a.m. each day.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Add file-expiration-days and file-cleanup-cron-spec configurations for storage sink to control the cleaning behavior of expired files`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 26, 2023
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 4, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 1, 2024
@purelind
Copy link
Collaborator

purelind commented Feb 1, 2024

/test all

@CharlesCheung96
Copy link
Contributor

/retest

16 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-10097-to-release-7.5 branch from 7cdfae2 to 3d2764a Compare February 7, 2024 08:26
@CharlesCheung96
Copy link
Contributor

/retest

15 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit f62807b into pingcap:release-7.5 Feb 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees

@CharlesCheung96 CharlesCheung96

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @purelind @CharlesCheung96