Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: cherry picks #9982 and #10054 #10165

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 27, 2023

What problem does this PR solve?

Cherry picks #9982 and #10054.

Issue Number: close #9980
Issue Number: close #10053

What is changed and how it works?

Cherry picks #9982 and #10054.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 27, 2023
@hicqu hicqu changed the title cherry picks #9982 and #10054 cdc: cherry picks #9982 and #10054 Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 27, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Nov 27, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 28, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 07:20:30.203031866 +0000 UTC m=+820858.868258045: ☑️ agreed by sdojjy.
  • 2023-11-28 00:58:07.841094731 +0000 UTC m=+884316.506320912: ☑️ agreed by nongfushanquan.

@ti-chi-bot ti-chi-bot bot merged commit af9cb77 into pingcap:release-6.5-20230923-v6.5.5 Nov 28, 2023
10 checks passed
@hicqu hicqu deleted the release-6.5-20230923-v6.5.5-9981 branch November 28, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants