puller(ticdc): detect resolved ts stuck in puller #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
sdojjy
changed the title
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
sdojjy
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
3AceShowHand
reviewed
Dec 1, 2023
| @@ -71,6 +71,10 @@ type pullerImpl struct { | |||
| changefeed model.ChangeFeedID | |||
| tableID model.TableID | |||
| tableName string | |||
|
|
|||
| cfg *config.ServerConfig | |||
There was a problem hiding this comment.
no need to store the server config, it's a global variable
3AceShowHand
approved these changes
Dec 1, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
asddongmen
approved these changes
Dec 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
sdojjy
added
needs-cherry-pick-release-6.5
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 1, 2023
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
This was referenced Dec 1, 2023
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 1, 2023
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 1, 2023
Signed-off-by: ti-chi-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10181
What is changed and how it works?
detect if the resolved ts is stuck, if so , restart the changefeed
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note