Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv-client(cdc): correct conditions of canceling grpc streams #10237

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 4, 2023

What problem does this PR solve?

Issue Number: close #10239
Issue Number: close #10136

What is changed and how it works?

Correct conditions of canceling grpc streams.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu added 2 commits December 4, 2023 13:42
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
hicqu added 2 commits December 4, 2023 14:46
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@hicqu hicqu changed the title Test cancel stream error kv-client(cdc): correct conditions of canceling grpc streams Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue labels Dec 4, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Dec 4, 2023

/retest

1 similar comment
@hicqu
Copy link
Contributor Author

hicqu commented Dec 4, 2023

/retest

@hicqu hicqu added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 08:41:21.850528274 +0000 UTC m=+1430510.515754467: ☑️ agreed by sdojjy.
  • 2023-12-04 08:59:45.515184412 +0000 UTC m=+1431614.180410607: ☑️ agreed by 3AceShowHand.

@hicqu hicqu merged commit cd0cb8f into pingcap:master Dec 4, 2023
13 checks passed
@hicqu hicqu deleted the test-cancel-stream-error branch December 4, 2023 09:05
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10240.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10241.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 4, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10242.

Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 4, 2023
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 4, 2023
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 5, 2023
hicqu added a commit that referenced this pull request Dec 5, 2023
* cdc: fixes minor bugs #10168 and #10169 (#10170)
* puller(cdc): debug frontier (#10202)
* kv-client(cdc): correct conditions of canceling grpc streams  (#10237)

Signed-off-by: qupeng <[email protected]>
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants