Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller(ticdc): fix stuck detect issue #10258

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Dec 6, 2023

What problem does this PR solve?

Issue Number: close #10256

What is changed and how it works?

check if the resolved ts is advanced before

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
cdc/puller/puller.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 6, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 6, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-06 02:38:56.564536523 +0000 UTC m=+1581565.229762716: ☑️ agreed by asddongmen.
  • 2023-12-06 03:01:21.29479311 +0000 UTC m=+1582909.960019296: ☑️ agreed by CharlesCheung96.

@sdojjy sdojjy merged commit e16c52d into pingcap:master Dec 6, 2023
6 of 13 checks passed
@sdojjy sdojjy deleted the fix-resovled-stuck branch December 6, 2023 03:08
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10259.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10260.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10261.

Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2023

@sdojjy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-storage-test b14e42e link true /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 6, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 6, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolved ts stucks when enable-resolved-ts-stuck-detection is on
4 participants