Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv-client(cdc): correct conditions of canceling grpc streams (#10237) #10268

Merged
merged 3 commits into from
Dec 7, 2023
Merged

kv-client(cdc): correct conditions of canceling grpc streams (#10237) #10268

merged 3 commits into from
Dec 7, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 7, 2023

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 05:14:32.831114015 +0000 UTC m=+1677301.496340210: ☑️ agreed by CharlesCheung96.
  • 2023-12-07 05:14:44.797155958 +0000 UTC m=+1677313.462382138: ☑️ agreed by nongfushanquan.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@hicqu
fix
d5d409c 
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 7, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Dec 7, 2023

/retest

1 similar comment
@hicqu
Copy link
Contributor Author

hicqu commented Dec 7, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3e07924 into pingcap:release-6.5-20230811-v6.5.3 Dec 7, 2023
10 checks passed
@hicqu hicqu deleted the release-6.5-20230811-v6.5.3-10237 branch December 7, 2023 12:48
This was referenced Dec 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hicqu @CharlesCheung96 @nongfushanquan