Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller(ticdc): refactor ddl puller remove verbose code and reduce logs #10297

Merged
merged 17 commits into from
Dec 20, 2023
Merged

puller(ticdc): refactor ddl puller remove verbose code and reduce logs #10297

merged 17 commits into from
Dec 20, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10296

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
asddongmen
asddongmen reviewed Dec 14, 2023
View reviewed changes
cdc/entry/mounter.go Outdated Show resolved Hide resolved
asddongmen
asddongmen reviewed Dec 14, 2023
View reviewed changes
cdc/entry/mounter.go Outdated Show resolved Hide resolved
asddongmen
asddongmen reviewed Dec 14, 2023
View reviewed changes
cdc/processor/processor.go
@@ -1007,10 +1007,6 @@ func (d *ddlHandler) Run(ctx context.Context, _ ...chan<- error) error {
if jobEntry.OpType == model.OpTypeResolved {
d.schemaStorage.AdvanceResolvedTs(jobEntry.CRTs)
}
err := jobEntry.Err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this error won't be checked, because it's already checked when the error happens.

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2023
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@asddongmen
Copy link
Contributor

Please make sure that the content of a DDL Job is printed at lease once in a log, such as in the run method in ddl_puller.go. This will be very helpful in debugging.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 19, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 07:18:48.647600864 +0000 UTC m=+945419.684827784: ☑️ agreed by asddongmen.
  • 2023-12-19 08:37:23.843031836 +0000 UTC m=+950134.880258764: ☑️ agreed by sdojjy.

CharlesCheung96
CharlesCheung96 reviewed Dec 19, 2023
View reviewed changes
cdc/entry/schema_storage.go
version int64
err error
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
err error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be removed, otherwise the snap become not used, report by the linter.

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit f0ab88a into pingcap:master Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 left review comments

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc refactor ddl puller to make log more clear and simplify code
4 participants
@3AceShowHand @asddongmen @sdojjy @CharlesCheung96