redo(cdc): custom redo event cache and disable it by default (#10139) #10315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
lgtm
release-note-none
ti-chi-bot
added
the
type/cherry-pick-for-release-6.5
hicqu
approved these changes
Dec 17, 2023
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: qupeng <[email protected]>
hicqu
force-pushed
the
cherry-pick-10139-to-release-6.5
branch
from
7dab125 to
c5377ba
Compare
ti-chi-bot
bot
added
size/M
|
/retest |
|
|
||
| // ConsistentMemoryUsage represents memory usage of Consistent module. | ||
| type ConsistentMemoryUsage struct { | ||
| MemoryQuotaPercentage uint64 `json:"memory_quota_percentage"` |
There was a problem hiding this comment.
redo_memory_quota_percentage
sdojjy
approved these changes
Dec 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10139
What problem does this PR solve?
Issue Number: close #10143
What is changed and how it works?
Why disable redo event cache by default?
Redo event cache is expected to reduce CPU and I/O usage for TiCDC. However, under a heavy workload cache hit ratio is usually
0, which means the cache doesn't make any help.In future, maybe we can generate sink/redo tasks based on
changefeeds instead oftables. Then we can enable redo cache again.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note