Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(cdc): custom redo event cache and disable it by default (#10139) #10316

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10139

What problem does this PR solve?

Issue Number: close #10143

What is changed and how it works?

  • allow to custom memory quota for redo;
  • allow to custom redo event cache;
  • disable redo event cache by default.

Why disable redo event cache by default?

Redo event cache is expected to reduce CPU and I/O usage for TiCDC. However, under a heavy workload cache hit ratio is usually 0, which means the cache doesn't make any help.

In future, maybe we can generate sink/redo tasks based on changefeeds instead of tables. Then we can enable redo cache again.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Dec 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 18, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 725d938 into pingcap:release-7.1 Dec 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants