Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: revert something from PR 10139 #10318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 17, 2023

What problem does this PR solve?

Issue Number: ref #10143

What is changed and how it works?

Revert something from PR #10139 . I guess it's introduced mistakely in branch manual merging.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2023
@hicqu hicqu changed the title revert something from PR 10139 cdc: revert something from PR 10139 Dec 17, 2023
@hicqu hicqu removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 17, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Dec 18, 2023

/retest

2 similar comments
@hicqu
Copy link
Contributor Author

hicqu commented Dec 18, 2023

/retest

@hicqu
Copy link
Contributor Author

hicqu commented Dec 19, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 07:29:50.619046373 +0000 UTC m=+946081.656273301: ☑️ agreed by asddongmen.
  • 2023-12-21 09:09:08.45518634 +0000 UTC m=+1124839.492413268: ☑️ agreed by CharlesCheung96.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 27, 2023

/retest

@purelind
Copy link
Collaborator

/test all

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #10318 (ec35122) into master (3e9c9de) will decrease coverage by 5.9148%.
Report is 337 commits behind head on master.
The diff coverage is 57.2286%.

Additional details and impacted files
Components Coverage Δ
cdc 61.8114% <57.2286%> (-1.5955%) ⬇️
dm 51.2214% <ø> (∅)
engine 63.3787% <ø> (∅)
Flag Coverage Δ
unit 57.4921% <57.2286%> (-5.9148%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10318        +/-   ##
================================================
- Coverage   63.4069%   57.4921%   -5.9148%     
================================================
  Files           392        849       +457     
  Lines         51067     126099     +75032     
================================================
+ Hits          32380      72497     +40117     
- Misses        16385      48184     +31799     
- Partials       2302       5418      +3116     

@asddongmen
Copy link
Contributor

/retest

5 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

2 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Feb 9, 2024

@hicqu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test ec35122 link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants