-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: revert something from PR 10139 #10318
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: qupeng <[email protected]>
/retest |
2 similar comments
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/test all |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10318 +/- ##
================================================
- Coverage 63.4069% 57.4921% -5.9148%
================================================
Files 392 849 +457
Lines 51067 126099 +75032
================================================
+ Hits 32380 72497 +40117
- Misses 16385 48184 +31799
- Partials 2302 5418 +3116 |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
2 similar comments
/retest |
/retest |
@hicqu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #10143
What is changed and how it works?
Revert something from PR #10139 . I guess it's introduced mistakely in branch manual merging.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note