mq (ticdc): make some code more readable. #10347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
sdojjy
approved these changes
Dec 22, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -83,3 +83,10 @@ func IsColumnValueEqual(preValue, updatedValue interface{}) bool { | |||
| // the value type should be the same | |||
| return preValue == updatedValue | |||
| } | |||
|
|
|||
| // TopicPartitionKey contains the topic and partition key of the message. | |||
| type TopicPartitionKey struct { | |||
There was a problem hiding this comment.
It looks like this should not be a part of the codec
There was a problem hiding this comment.
Put it here can make the import graph happier, and actually, the encoderGroup in the codec package already relies on the topic and partition information.
3AceShowHand
approved these changes
Dec 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10348
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note