Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): return internal error in redo writer #11011

Merged
merged 2 commits into from
May 14, 2024
Merged

redo(ticdc): return internal error in redo writer #11011

merged 2 commits into from
May 14, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Apr 29, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10124

What is changed and how it works?

  • return internal error in redo writer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 29, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Apr 29, 2024
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review May 6, 2024 03:21
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@asddongmen
Copy link
Contributor

Please refine the pull request description.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 8, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.7633%. Comparing base (ba6db07) to head (4d3c7ef).
Report is 19 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.2676% <84.2105%> (+0.5620%) ⬆️
dm 51.3811% <ø> (+0.1283%) ⬆️
engine 63.4444% <ø> (+0.0564%) ⬆️
Flag Coverage Δ
unit 57.7633% <84.2105%> (+0.3491%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11011        +/-   ##
================================================
+ Coverage   57.4142%   57.7633%   +0.3491%     
================================================
  Files           851        851                
  Lines        125225     126350      +1125     
================================================
+ Hits          71897      72984      +1087     
- Misses        47936      47952        +16     
- Partials       5392       5414        +22

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-08 06:19:26.753972583 +0000 UTC m=+1029320.511108157: ☑️ agreed by hongyunyan.
  • 2024-05-14 01:55:43.86685993 +0000 UTC m=+1531897.623995503: ☑️ agreed by sdojjy.

@ti-chi-bot ti-chi-bot bot merged commit 52b4301 into pingcap:master May 14, 2024
28 checks passed
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels May 14, 2024
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11090.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 14, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11011
9c223e9 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 14, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11011
b7361b3 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11091.

@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11092.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 14, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11011
3dbf2fc 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11093.

@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2024
@ti-chi-bot
redo(ticdc): return internal error in redo writer (#11011) (#11093)
5090def 
close #10124
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 21, 2024
@CharlesCheung96
redo(ticdc): return internal error in redo writer (pingcap#11011)
babff66 
close pingcap#10124
ti-chi-bot bot pushed a commit that referenced this pull request May 22, 2024
@ti-chi-bot
redo(ticdc): return internal error in redo writer (#11011) (#11090)
6ec0dc5 
close #10124
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 6, 2024
@CharlesCheung96
redo(ticdc): return internal error in redo writer (pingcap#11011)
9129026 
close pingcap#10124
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 11, 2024
@CharlesCheung96
redo(ticdc): return internal error in redo writer (pingcap#11011)
6403976 
close pingcap#10124
ti-chi-bot bot pushed a commit that referenced this pull request Jun 11, 2024
@ti-chi-bot
redo(ticdc): return internal error in redo writer (#11011) (#11091)
327ba7b 
close #10124
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <[email protected]>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <[email protected]>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <[email protected]>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <[email protected]>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <[email protected]>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <[email protected]>
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 4, 2024
@ti-chi-bot @CharlesCheung96
redo(ticdc): return internal error in redo writer (pingcap#11011) (pi…
8e9573d 
…ngcap#11090)

close pingcap#10124
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@ti-chi-bot
redo(ticdc): return internal error in redo writer (#11011) (#11092)
b84e34b 
close #10124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyunyan hongyunyan hongyunyan approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc: after redo changefeed reported error and resumed the changefeed , redolog writer is closed
5 participants
@CharlesCheung96 @asddongmen @ti-chi-bot @sdojjy @hongyunyan