Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: reset optimistic sharding group keeper when syncer resume #9707

Merged
merged 1 commit into from
Sep 11, 2023
Merged

dm: reset optimistic sharding group keeper when syncer resume #9707

merged 1 commit into from
Sep 11, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 8, 2023

What problem does this PR solve?

Issue Number: close #9588

What is changed and how it works?

  • reset optimistic sharding group keeper when syncer resume

Root Cause

when syncer resume, the remain sharding group keeper infos will block replication if we not reset it

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-08 05:50:18.709726785 +0000 UTC m=+2683783.258742772: ☑️ agreed by lichunzhu.
  • 2023-09-08 05:54:31.90175732 +0000 UTC m=+2684036.450773306: ☑️ agreed by okJiang.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 8, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 8, 2023

/retest

2 similar comments
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 8, 2023

/retest

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 78d59fc into pingcap:master Sep 11, 2023
2 of 3 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #9716.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 11, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#9707
f750bf7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #9717.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Open
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 11, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#9707
2b16d51 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9718.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9719.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9720.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2023
@ti-chi-bot
dm: reset optimistic sharding group keeper when syncer resume (#9707) (…
b9bee64 
…#9719)

close #9588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm: OptShardingGroupKeeper should be reset when resume task
5 participants
@GMHDBJD @lance6716 @ti-chi-bot @lichunzhu @okJiang