Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openAPI (ticdc): fix openapi use old addrs to create pdClient #9713

Merged
merged 3 commits into from
Sep 18, 2023
Merged

openAPI (ticdc): fix openapi use old addrs to create pdClient #9713

merged 3 commits into from
Sep 18, 2023

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9584

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix a bug that may cause TiCDC OpenAPI fails when PD scale-in after scale-out.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 8, 2023
@asddongmen asddongmen requested a review from sdojjy September 8, 2023 07:59
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 02:33:30.7283592 +0000 UTC m=+484776.695947235: ☑️ agreed by sdojjy.
  • 2023-09-18 02:45:13.186433348 +0000 UTC m=+485479.154021397: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2023
@asddongmen
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@asddongmen
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8e346aa into pingcap:master Sep 18, 2023
3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9764.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 18, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 18, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#9713
1ca28a0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9765.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 18, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#9713
3c13c0a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 18, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Sep 19, 2023
@ti-chi-bot
openAPI (ticdc): fix openapi use old addrs to create pdClient (#9713) (…
8416cad 
…#9765)

close #9584
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2023
@ti-chi-bot
openAPI (ticdc): fix openapi use old addrs to create pdClient (#9713) (…
6a31202 
…#9764)

close #9584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The CDC client is still using the old PD address
4 participants
@asddongmen @ti-chi-bot @sdojjy @3AceShowHand