Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/election(ticdc): implement gorm based election #9752

Merged
merged 5 commits into from
Sep 22, 2023
Merged

pkg/election(ticdc): implement gorm based election #9752

merged 5 commits into from
Sep 22, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9768

What is changed and how it works?

  1. Update different rows bansed on isLeaderChanged

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 14, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 14, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review September 14, 2023 16:33
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/test all

@asddongmen asddongmen self-requested a review September 18, 2023 08:56
@CharlesCheung96 CharlesCheung96 added area/ticdc Issues or PRs related to TiCDC. type/feature Issues about a new feature labels Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 18, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/check-issue-triage-complete

@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 20, 2023
@CharlesCheung96
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 02:49:34.169909174 +0000 UTC m=+658540.137497224: ☑️ agreed by sdojjy.
  • 2023-09-20 08:53:18.372081989 +0000 UTC m=+680364.339670060: ☑️ agreed by asddongmen.

@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/label ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 22, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7ad8876 into pingcap:master Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
approved area/ticdc Issues or PRs related to TiCDC. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement gorm based election
3 participants
@CharlesCheung96 @sdojjy @asddongmen