Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ticdc): add utf8mb4_0900_ai_ci tests #9781

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 21, 2023

What problem does this PR solve?

Issue Number: close #9796

What is changed and how it works?

Add utf8mb4_0900_ai_ci related tests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 21, 2023
@sre-bot
Copy link

sre-bot commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 21, 2023
@zimulala
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-22 08:23:42.786025516 +0000 UTC m=+4012.504367731: ☑️ agreed by sdojjy.
  • 2023-09-22 08:31:12.336662149 +0000 UTC m=+4462.055004365: ☑️ agreed by 3AceShowHand.

@sdojjy
Copy link
Member

sdojjy commented Sep 22, 2023

/check-issue-triage-complete

@sdojjy
Copy link
Member

sdojjy commented Sep 22, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 2edb6db into pingcap:master Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utf8mb4_0900_ai_ci related tests
4 participants