Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql (ticdc): fix batch dml delete sql gennerate error #9813

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Sep 26, 2023

What problem does this PR solve?

Issue Number: close #9812

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 26, 2023
@asddongmen
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue labels Sep 26, 2023
@asddongmen asddongmen force-pushed the fix_batch_dml_generate_delete branch from d16d721 to 7ea72b9 Compare September 26, 2023 08:16
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/retest

2 similar comments
@nongfushanquan
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor Author

/retest

@sdojjy
Copy link
Member

sdojjy commented Sep 27, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member

sdojjy commented Sep 27, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 28, 2023
@asddongmen asddongmen force-pushed the fix_batch_dml_generate_delete branch from 8764f7c to fd92104 Compare November 1, 2023 07:00
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2023
cdc/entry/mounter_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

cdc/model/sink.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 1, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-28 05:51:54.346165295 +0000 UTC m=+81111.933275440: ☑️ agreed by nongfushanquan.
  • 2023-11-01 07:17:42.399403078 +0000 UTC m=+3023859.986513208: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 3dc797b into pingcap:master Nov 1, 2023
3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9987.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9988.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9989.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiCDC did not correctly use the primary key as the where clause for the Delete statement.
5 participants