Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: disable kv-client.enable-multiplexing by default #9844

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Oct 9, 2023

What problem does this PR solve?

Issue Number: close #9673

What is changed and how it works?

Disable kv-client.enable-multiplexing by default.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 9, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 9, 2023
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-09 08:22:25.820631466 +0000 UTC m=+1040543.407741611: ☑️ agreed by nongfushanquan.
  • 2023-10-09 08:22:35.452079352 +0000 UTC m=+1040553.039189494: ☑️ agreed by 3AceShowHand.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hicqu
Copy link
Contributor Author

hicqu commented Oct 9, 2023

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit f55de7f into pingcap:release-7.4 Oct 9, 2023
3 checks passed
@hicqu hicqu deleted the 7.4-disable-multiplexing branch October 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants