Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): fix redo initialization block the owner #9887

Merged
merged 30 commits into from
Nov 1, 2023
Merged

redo(ticdc): fix redo initialization block the owner #9887

merged 30 commits into from
Nov 1, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9886

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

none

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2023
@3AceShowHand 3AceShowHand changed the title redo(ticdc): add some logs about read redo meta. [DNM]redo(ticdc): add some logs about read redo meta. Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2023
@3AceShowHand 3AceShowHand removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@3AceShowHand 3AceShowHand changed the title [DNM]redo(ticdc): add some logs about read redo meta. [DNM]redo(ticdc): fix redo initialization block the owner Oct 16, 2023
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2023
@3AceShowHand 3AceShowHand changed the title [DNM]redo(ticdc): fix redo initialization block the owner redo(ticdc): fix redo initialization block the owner Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 08:43:06.268338024 +0000 UTC m=+2856183.855448167: ☑️ agreed by CharlesCheung96.
  • 2023-10-30 23:34:42.232004031 +0000 UTC m=+2909679.819114177: ☑️ agreed by sdojjy.

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-storage-test

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@CharlesCheung96 CharlesCheung96 mentioned this pull request Nov 1, 2023
Closed
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit 684d117 into pingcap:master Nov 1, 2023
3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9991.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 1, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9887
20018eb 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 1, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9887
f4582af 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9992.

This was referenced Nov 1, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9993.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 1, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9887
7ba747a 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 2, 2023
@ti-chi-bot
redo(ticdc): fix redo initialization block the owner (#9887) (#9993)
87785f1 
close #9886
ti-chi-bot bot pushed a commit that referenced this pull request Nov 3, 2023
@ti-chi-bot
redo(ticdc): fix redo initialization block the owner (#9887) (#9992)
ba5bced 
close #9886
ti-chi-bot bot pushed a commit that referenced this pull request Nov 14, 2023
@ti-chi-bot
redo(ticdc): fix redo initialization block the owner (#9887) (#9991)
21033a4 
close #9886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@sdojjy sdojjy sdojjy approved these changes

@hicqu hicqu Awaiting requested review from hicqu

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redo read metadata may block the owner and read bad data
4 participants
@3AceShowHand @ti-chi-bot @sdojjy @CharlesCheung96