Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv-client(cdc): log slowest regions and region holes #9933

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Oct 20, 2023

What problem does this PR solve?

Issue Number: ref #9222

What is changed and how it works?

Log slowest regions and region holes to help debug potential bugs.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu added 2 commits October 18, 2023 14:09
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 06:38:01.924482568 +0000 UTC m=+1984679.511592713: ☑️ agreed by sdojjy.
  • 2023-10-20 06:44:11.245661733 +0000 UTC m=+1985048.832771878: ☑️ agreed by 3AceShowHand.

@hicqu
Copy link
Contributor Author

hicqu commented Oct 20, 2023

/retest-required

@hicqu
Copy link
Contributor Author

hicqu commented Oct 20, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit a71208a into pingcap:master Oct 20, 2023
3 checks passed
@hicqu hicqu deleted the log-slowest-regions branch October 20, 2023 08:52
@hicqu hicqu added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9985.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 1, 2023
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants