Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler(ticdc): revert 3b8d55 and do not return error when resolvedTs less than checkpoint (#9953) #9957

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cdc/owner/changefeed.go
Original file line number Diff line number Diff line change
Expand Up @@ -447,19 +447,27 @@
}
}

<<<<<<< HEAD

Check failure on line 450 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected <<, expected }

Check failure on line 450 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected <<, expected }
checkpointTs := c.state.Status.CheckpointTs
if c.resolvedTs == 0 {
c.resolvedTs = checkpointTs
}

minTableBarrierTs := c.state.Status.MinTableBarrierTs
=======
checkpointTs := c.latestStatus.CheckpointTs
if c.resolvedTs == 0 {
c.resolvedTs = checkpointTs
}
minTableBarrierTs := c.latestStatus.MinTableBarrierTs
>>>>>>> 0c29040814 (scheduler(ticdc): revert 3b8d55 and do not return error when resolvedTs less than checkpoint (#9953))

Check failure on line 463 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

invalid character U+0023 '#'

Check failure on line 463 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

invalid character U+0023 '#'

failpoint.Inject("NewChangefeedNoRetryError", func() {

Check failure on line 465 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

method has no receiver

Check failure on line 465 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected {, expected name

Check failure on line 465 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

method has no receiver

Check failure on line 465 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected {, expected name
failpoint.Return(cerror.ErrStartTsBeforeGC.GenWithStackByArgs(checkpointTs-300, checkpointTs))
})

Check failure on line 467 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected ) after top level declaration

Check failure on line 467 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected ) after top level declaration
failpoint.Inject("NewChangefeedRetryError", func() {

Check failure on line 468 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

method has no receiver

Check failure on line 468 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected {, expected name

Check failure on line 468 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

method has no receiver

Check failure on line 468 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected {, expected name
failpoint.Return(errors.New("failpoint injected retriable error"))
})

Check failure on line 470 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected ) after top level declaration

Check failure on line 470 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected ) after top level declaration

if c.state.Info.Config.CheckGCSafePoint {
// Check TiDB GC safepoint does not exceed the checkpoint.
Expand Down Expand Up @@ -508,7 +516,7 @@
// For example, if the ddl job is `add index`, TiCDC will execute the ddl
// job again and cause the index to be added twice. We need to fix this
// problem in the future. See:https://github.com/pingcap/tiflow/issues/2543
if checkpointTs == minTableBarrierTs {

Check failure on line 519 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: non-declaration statement outside function body

Check failure on line 519 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: non-declaration statement outside function body
ddlStartTs = checkpointTs - 1
} else {
ddlStartTs = checkpointTs
Expand Down Expand Up @@ -548,7 +556,7 @@
zap.String("changefeed", c.id.ID),
)

c.ddlSink = c.newSink(c.id, c.state.Info, ctx.Throw, func(err error) {

Check failure on line 559 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Arm Build (ARM64)

syntax error: unexpected {, expected name

Check failure on line 559 in cdc/owner/changefeed.go

View workflow job for this annotation

GitHub Actions / Mac OS Build

syntax error: unexpected {, expected name
select {
case <-ctx.Done():
case c.warningCh <- err:
Expand Down
Loading