Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler(ticdc): revert 3b8d55 and do not return error when resolvedTs less than checkpoint (#9953) #9958

Merged
merged 2 commits into from
Oct 30, 2023
Merged

scheduler(ticdc): revert 3b8d55 and do not return error when resolvedTs less than checkpoint (#9953) #9958

merged 2 commits into from
Oct 30, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9953

What problem does this PR solve?

Issue Number: ref #9830, ref #9926

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 26, 2023
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 26, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-9953-to-release-7.5 branch from 57498f2 to 81f029e Compare October 27, 2023 08:39
@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4f5f3eb into pingcap:release-7.5 Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees

@CharlesCheung96 CharlesCheung96

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @CharlesCheung96