Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add more event for incompatible ddl changes #9978

Merged
merged 4 commits into from
Nov 3, 2023
Merged

dm: add more event for incompatible ddl changes #9978

merged 4 commits into from
Nov 3, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Oct 31, 2023

What problem does this PR solve?

Issue Number: close #9692

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2023
lichunzhu
lichunzhu approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
Benjamin2037
Benjamin2037 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lichunzhu, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 08:57:02.806121973 +0000 UTC m=+2943420.393232115: ☑️ agreed by lichunzhu.
  • 2023-11-02 08:32:26.453815463 +0000 UTC m=+3114744.040925607: ☑️ agreed by okJiang.

@okJiang
Copy link
Member

okJiang commented Nov 2, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 2, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 3, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 3, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 3, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 3, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1397f3f into pingcap:master Nov 3, 2023
3 checks passed
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 6, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 6, 2023

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10011.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM supports intercepting incompatible DDL changes during Synchronization
5 participants
@GMHDBJD @okJiang @ti-chi-bot @Benjamin2037 @lichunzhu