Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config, changefeed (ticdc): add sql mode config for changefeed (#9941) #9996

Merged
merged 4 commits into from
Nov 8, 2023
Merged

config, changefeed (ticdc): add sql mode config for changefeed (#9941) #9996

merged 4 commits into from
Nov 8, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9941

What problem does this PR solve?

Issue Number: close #9876

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Add sql mode config for changefeed

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 2, 2023
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 2, 2023
@asddongmen
Copy link
Contributor

/retest

2 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 7, 2023
@asddongmen
Copy link
Contributor

/retest

6 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit a4f5874 into pingcap:release-7.5 Nov 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

Assignees

@asddongmen asddongmen

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @asddongmen @nongfushanquan