fix tests

pinterest · Nov 14, 2024 · 5110eba · 5110eba
1 parent 03990e2
commit 5110eba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...service/teletraanservice/src/test/java/com/pinterest/teletraan/handler/EnvStagesTest.java b/...service/teletraanservice/src/test/java/com/pinterest/teletraan/handler/EnvStagesTest.java
@@ -67,7 +67,7 @@ public void updateEnvStageOffDev_unsetsAllowPrivateBuild() throws Exception {
         origBean.setStage_type(EnvType.DEV);
         envBean.setStage_type(EnvType.STAGING);
         Mockito.when(environDAO.getByStage(Mockito.anyString(), Mockito.anyString()))
-            .thenReturn(origBean);
+                .thenReturn(origBean);
         SecurityContext mockSC = mock(SecurityContext.class);
         Principal mockPrincipal = mock(Principal.class);
         Mockito.when(mockSC.getUserPrincipal()).thenReturn(mockPrincipal);

diff --git a/...rc/test/java/com/pinterest/teletraan/universal/security/ScriptTokenAuthenticatorTest.java b/...rc/test/java/com/pinterest/teletraan/universal/security/ScriptTokenAuthenticatorTest.java
@@ -23,6 +23,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import com.pinterest.teletraan.universal.security.bean.AuthZResource;
 import com.pinterest.teletraan.universal.security.bean.ScriptTokenPrincipal;
 import com.pinterest.teletraan.universal.security.bean.ValueBasedRole;
 import io.dropwizard.auth.AuthenticationException;
@@ -50,12 +51,14 @@ void setUp() throws Exception {
         registry = new SimpleMeterRegistry();
         Metrics.addRegistry(registry);
 
+        scriptTokenPrincipal =
+                new ScriptTokenPrincipal<ValueBasedRole>(
+                        PRINCIPAL_NAME, new ValueBasedRole(1), new AuthZResource("rId", "rType"));
+
         scriptTokenProvider = mock(ScriptTokenProvider.class);
-        scriptTokenPrincipal = mock(ScriptTokenPrincipal.class);
         when(scriptTokenProvider.getPrincipal(anyString())).thenReturn(Optional.empty());
         when(scriptTokenProvider.getPrincipal(CREDENTIALS))
                 .thenReturn(Optional.of(scriptTokenPrincipal));
-        when(scriptTokenPrincipal.getName()).thenReturn(PRINCIPAL_NAME);
 
         sut = new ScriptTokenAuthenticator<>(scriptTokenProvider);
     }