address some comments

pinterest · Oct 19, 2023 · 8564a36 · 8564a36
1 parent 46689cd
commit 8564a36
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/deploy-agent/deployd/agent.py b/deploy-agent/deployd/agent.py
@@ -128,7 +128,7 @@ def serve_build(self):
             for status in self._envs.values():
                 # for each container, we check the health status
                 try:
-                    healthStatus = utils.get_container_health_info(status.build_info.build_commit)
+                    healthStatus = get_container_health_info(status.build_info.build_commit)
                     if healthStatus:
                         status.report.containerHealthStatus = healthStatus
                     else:

diff --git a/deploy-agent/deployd/common/utils.py b/deploy-agent/deployd/common/utils.py
@@ -239,10 +239,7 @@ def get_container_health_info(commit):
                             result = result + name + ":" + status.decode().strip() + ";"
                     except:
                         continue
-            if result != "":    
-                return result
-            else:
-                return None
+            return result if result else None
         else:
             return None
     except: