Revert changes for error budget

pinterest · Oct 13, 2023 · c0a02d2 · c0a02d2
1 parent c0380ec
commit c0a02d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/deploy-service/common/src/main/java/com/pinterest/deployservice/ServiceContext.java b/deploy-service/common/src/main/java/com/pinterest/deployservice/ServiceContext.java
@@ -49,8 +49,6 @@
 import com.pinterest.deployservice.scm.SourceControlManagerProxy;
 import com.pinterest.teletraan.universal.events.AppEventPublisher;
 
-import io.micrometer.core.instrument.MeterRegistry;
-
 import org.apache.commons.dbcp.BasicDataSource;
 
 import java.util.List;

diff --git a/...main/java/com/pinterest/teletraan/universal/metrics/micrometer/PinStatsMeterRegistry.java b/...main/java/com/pinterest/teletraan/universal/metrics/micrometer/PinStatsMeterRegistry.java
@@ -2,7 +2,6 @@
 
 import io.micrometer.core.instrument.Clock;
 import io.micrometer.core.instrument.Meter;
-import io.micrometer.core.instrument.config.NamingConvention;
 import io.micrometer.core.instrument.util.MeterPartition;
 import io.micrometer.core.instrument.util.NamedThreadFactory;
 import io.micrometer.opentsdb.OpenTSDBMeterRegistry;
@@ -20,20 +19,12 @@ public class PinStatsMeterRegistry extends OpenTSDBMeterRegistry {
   private final PinStatsPublisher publisher;
 
   public PinStatsMeterRegistry(PinStatsConfig config, Clock clock) {
-    this(config, clock, null, new PinStatsNamingConvention(config.namePrefix()));
+    this(config, clock, null);
   }
 
   public PinStatsMeterRegistry(PinStatsConfig config, Clock clock, PinStatsPublisher publisher) {
-    this(config, clock, publisher, new PinStatsNamingConvention(config.namePrefix()));
-  }
-
-  public PinStatsMeterRegistry(PinStatsConfig config, Clock clock, NamingConvention namingConvention) {
-    this(config, clock, null, namingConvention);
-  }
-
-  public PinStatsMeterRegistry(PinStatsConfig config, Clock clock, PinStatsPublisher publisher, NamingConvention namingConvention) {
     super(config, clock, DEFAULT_THREAD_FACTORY, null);
-    config().namingConvention(namingConvention);
+    config().namingConvention(new PinStatsNamingConvention(config.namePrefix()));
     this.config = config;
     this.publisher =
         publisher == null
@@ -52,4 +43,4 @@ protected void publish() {
       }
     }
   }
-}
+}