Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send stage type from TAS to the host and setup the environment variable #1344

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

liyaqin1
Copy link
Contributor

No description provided.

@liyaqin1 liyaqin1 requested a review from a team as a code owner November 17, 2023 00:39
@liyaqin1
Copy link
Contributor Author

Tested between my devapp and Teletraan dev1.
The logs look good.
TAS log:
{"level":"INFO","logger":"com.pinterest.deployservice.handler.PingHandler","thread":"dw-24 - POST /v1/system/ping","message":"Return response com.pinterest.deployservice.bean.PingResponseBean@44ec40fe[opCode=DEPLOY,deployGoal=com.pinterest.deployservice.bean.DeployGoalBean@3fdc976a[deployId=8M6Sgx4SRnaFC2rwhxfjBw,deployType=REGULAR,envId=8ss-6DLmQeWe7EMejOVWEw,envName=deploy-open-sentinel-dev1,stageName=test-timeout,stageType=DEFAULT,deployStage=PRE_DOWNLOAD,build=<null>,deployAlias=<null>,agentConfigs={STOPPING.process_timeout=12000},scriptVariables=<null>,firstDeploy=false,isDocker=false]] for host dev-yaqinli.","timestamp":"2023-11-17T02:39:45.561+0000"}
Deployd log:

2023-11-17 02:47:52,252 deployd.common.executor:54 DEBUG Executor configs have been updated: PING_INTERVAL=60, TIME_OUT=1800, MAX_RETRY=3
2023-11-17 02:47:52,252 deployd:444 INFO current deploy goal is: DeployGoal(deployId=8M6Sgx4SRnaFC2rwhxfjBw, envId=8ss-6DLmQeWe7EMejOVWEw, envName=deploy-open-sentinel-dev1, stageName=test-timeout, stageType=DEFAULT, deployStage=PRE_DOWNLOAD, build=None, deployAlias=None, agentConfig={'STOPPING.process_timeout': '12000'},scriptVariables=None, firstDeploy=False, isDocker=False)

ntascii
ntascii previously approved these changes Nov 17, 2023
Copy link
Contributor

@ntascii ntascii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update UTs or add new test for this change?

@liyaqin1
Copy link
Contributor Author

can we update UTs or add new test for this change?

Hi Anh, I tested via this new build on my devapp: #1345
https://deploy-dev1.pinadmin.com/env/deploy-open-sentinel-dev1/test-timeout/
Screenshot 2023-11-17 at 11 43 31 AM
And you can see the stage type DEFAULT is printed out as expected:
Screenshot 2023-11-17 at 11 35 32 AM

Copy link
Contributor

@ntascii ntascii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liyaqin1 liyaqin1 merged commit 673c4cd into master Nov 17, 2023
6 checks passed
@liyaqin1 liyaqin1 deleted the yaqin/sendStageType branch November 17, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants