Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce universal/security library for AuthN and AuthZ #1486

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Mar 2, 2024

This change reimplements the AuthN and AuthZ components.

Had to change the github workflows to include internal dependencies in order to get this pass PR validations.

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Things remaining

  • More test coverage
  • Javadoc

@tylerwowen tylerwowen requested a review from a team as a code owner March 2, 2024 00:25
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Mar 2, 2024
@tylerwowen tylerwowen added this to the Teletraan AuthN & AuthZ milestone Mar 2, 2024
Copy link
Contributor

@vitalii-honchar vitalii-honchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially reviewed a PR. Major comments:

  • Please use Java best practices and move newly created constants from the local declarations to private static final fields.
  • Please use single responsibility principle and don't create dependencies of some class inside it's constructor. If class depends on something, inject it as the dependency and leave the responsibility of the dependency creation to the client of the class.
  • Please review code with Intelij Idea and remove highlighted unnecessary parts like public access modifier in the interface methods.
  • Please use Lombok var and Slf4j annotations to create local variable or declare logger, let's try to use modern software engineering practices in Java 8 with Lombok.

vitalii-honchar
vitalii-honchar previously approved these changes Mar 6, 2024
Copy link
Contributor

@vitalii-honchar vitalii-honchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaved optional comments.

@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Mar 12, 2024
@tylerwowen tylerwowen force-pushed the spr/master/17aa4dbb branch 2 times, most recently from d693afd to 88786fa Compare March 13, 2024 00:21
@github-actions github-actions bot removed the deploy-board Includes changes to deploy-board label Mar 13, 2024
@tylerwowen tylerwowen merged commit 3eda73e into master Mar 13, 2024
5 checks passed
@tylerwowen tylerwowen deleted the spr/master/17aa4dbb branch March 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants