Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce pre-commit hooks on pull requests #1636

Merged
merged 4 commits into from
May 31, 2024
Merged

Enforce pre-commit hooks on pull requests #1636

merged 4 commits into from
May 31, 2024

Conversation

gzpcho
Copy link
Contributor

@gzpcho gzpcho commented May 30, 2024 •
edited
Loading

@github-actions github-actions bot added deploy-board Includes changes to deploy-board deploy-agent Includes changes to deploy-agent labels May 30, 2024
@github-actions github-actions bot removed deploy-board Includes changes to deploy-board deploy-agent Includes changes to deploy-agent labels May 30, 2024
@gzpcho gzpcho marked this pull request as ready for review May 30, 2024 21:39
@gzpcho gzpcho requested a review from a team as a code owner May 30, 2024 21:39
@gzpcho gzpcho requested a review from osoriano May 30, 2024 22:12
osoriano
osoriano approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@osoriano osoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are not too many lint errors right now, so I could follow up with a PR to address it

@gzpcho gzpcho merged commit 264c0ce into master May 31, 2024
6 checks passed
@gzpcho gzpcho deleted the iroquebert/pre-commit-github-action branch May 31, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osoriano osoriano osoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzpcho @osoriano