Toggle the ZeroChecksum heuristics

Toggle every 3 packets in cases of heavy packet loss to allow Association to recover
pion · Apr 3, 2024 · 5422eb6 · 5422eb6
1 parent b6135a7
commit 5422eb6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/association.go b/association.go
@@ -2556,9 +2556,9 @@ func (a *Association) onRetransmissionTimeout(id int, nRtos uint) {
 	defer a.lock.Unlock()
 
 	// TSN hasn't been incremented in 3 attempts. Speculatively
-	// disable ZeroChecksum because old Pion versions had a broken implementation
-	if a.cumulativeTSNAckPoint+1 == a.initialTSN && nRtos == 3 {
-		a.sendZeroChecksum = false
+	// toggle ZeroChecksum because old Pion versions had a broken implementation
+	if a.cumulativeTSNAckPoint+1 == a.initialTSN && nRtos%3 == 0 {
+		a.sendZeroChecksum = !a.sendZeroChecksum
 	}
 
 	if id == timerT1Init {