Implement draft-ietf-tsvwg-sctp-zero-checksum-01

[mengelbart]

Description

Implementation of draft-ietf-tsvwg-sctp-zero-checksum-01.

I currently don't have a specific use case for this, but implementing the draft was an interesting exercise. I suggest keeping this as draft PR, at least until the document is finalized.

[codecov]

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (2927025) 80.59% compared to head (b168526) 80.56%.

Files	Patch %	Lines
association.go	89.09%	4 Missing and 2 partials ⚠️
param_zero_checksum.go	60.00%	4 Missing and 2 partials ⚠️
packet.go	76.92%	2 Missing and 1 partial ⚠️
paramtype.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   80.59%   80.56%   -0.04%     
==========================================
  Files          48       49       +1     
  Lines        4056     4121      +65     
==========================================
+ Hits         3269     3320      +51     
- Misses        644      654      +10     
- Partials      143      147       +4     

Flag	Coverage Δ
go	80.56% <80.45%> (-0.04%)	⬇️
wasm	66.90% <44.82%> (-0.41%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tuexen]

Question, maybe also for @Sean-Der : What possibilities of collaboration do exist? Only by commenting or is there a way to propose changes to a PR?

[mengelbart]

Hi @tuexen! You can add suggestions in the comments (there's a little icon in the comments UI where you can directly suggest code changes), or I think you can also open a PR against this branch. I also don't mind if you directly push to this branch, but I think that only works if you are a member of the pion org. (if not, I think @Sean-Der can add you as a member?)

[Sean-Der]

Done! You can directly push to branches now @tuexen

Everyone just needs one approval to merge to master :)

[tuexen]

Done! You can directly push to branches now @tuexen

Great thanks. This makes things much simpler.

Everyone just needs one approval to merge to master :)

Great. I'll be conservative, since I'm new to go...

[Sean-Der]

Anything I can do to help @mengelbart ? Seems like this is really close, would love to get it in :)

[mengelbart]

I think it is almost done. The IETF draft changed a bit since I first implemented it. I don't think it requires changes in this patch but someone should probably review that again. And I think the code needs to be reviewed in general :)

[daweifeng]

I have been using this branch in my project for a month and I haven't seen any issues so far. It is compatible with the C++ zero checksum implementation in libdatachannel

[matthewfarstad]

Very excited for this to be merged. Until then I will be using the PR.