Fix checksum check for received packets #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the following packets should be accepted: * Packets with a correct CRC32c checksum. * Packets with an incorrect zero checksum, if its acceptance is allowed. In particular, packets with an incorrect non-zero CRC32c must be discarded.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 80.66% 80.62% -0.05%
==========================================
Files 49 49
Lines 4123 4123
==========================================
- Hits 3326 3324 -2
- Misses 652 653 +1
- Partials 145 146 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'll try to look at this Monday! |
Great thanks! I also have a local patch to fix the handling of the parameter during the handshake. But I'll submit that one, once this has been dealt with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the following packets should be accepted:
In particular, packets with an incorrect non-zero CRC32c must be discarded.