Unmarshal packets only once #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 80.71% 80.81% +0.09%
==========================================
Files 49 49
Lines 4133 4133
==========================================
+ Hits 3336 3340 +4
+ Misses 652 649 -3
+ Partials 145 144 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Unmarshal of a packet should only be done once, since doing it multiple times ends up in an incorrect list of chunks. Also, perform checksum validation first. For pion, the only chunks requiring a correct CRC32c are the INIT and COOKIE-ECHO chunks, which need to be the first chunk in a packet.
tuexen
requested review from
mengelbart,
enobufs and
edaniels
and removed request for
enobufs
edaniels
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
hehe this is better than my fix here https://github.com/pion/sctp/pull/302/files#diff-b094e403b6f9c6dc300207a21d074085bc52a37548e49aeeb79c17e54f592748R693 :). LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmarshal of a packet should only be done once, since doing it multiple times ends up in an incorrect list of chunks. Also, perform checksum validation first.
For pion, the only chunks requiring a correct CRC32c are the INIT and COOKIE-ECHO chunks, which need to be the first chunk in a packet (as long as the stack does not support SCTP AUTH).