Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some RFC based comments #306

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Add some RFC based comments #306

merged 1 commit into from
Mar 3, 2024

Conversation

edaniels
Copy link
Member

No description provided.

@edaniels edaniels requested a review from daonb February 28, 2024 15:11
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.92%. Comparing base (19e73c4) to head (daa0dc7).

Files Patch % Lines
association.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   80.87%   80.92%   +0.04%     
==========================================
  Files          49       49              
  Lines        4157     4167      +10     
==========================================
+ Hits         3362     3372      +10     
  Misses        651      651              
  Partials      144      144              
Flag Coverage Δ
go 80.92% <93.75%> (+0.04%) ⬆️
wasm 67.31% <81.25%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rtx_timer.go Outdated Show resolved Hide resolved
@edaniels edaniels requested a review from daonb March 1, 2024 17:25
@edaniels edaniels merged commit 1e43ebf into pion:master Mar 3, 2024
13 checks passed
@edaniels edaniels deleted the rfc_comments branch March 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants