Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to COOKIE_WAIT after T1-init start #310

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

edaniels
Copy link
Member

Description

Inconsequential but follows the language of the RFC better

@edaniels edaniels requested a review from tuexen February 28, 2024 16:24
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (735a4c6) to head (58e153c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   80.96%   81.01%   +0.05%     
==========================================
  Files          49       49              
  Lines        4177     4178       +1     
==========================================
+ Hits         3382     3385       +3     
+ Misses        651      650       -1     
+ Partials      144      143       -1     
Flag Coverage Δ
go 81.01% <100.00%> (+0.05%) ⬆️
wasm 67.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels requested a review from daonb March 3, 2024 13:52
Copy link
Contributor

@daonb daonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment but it's up to you whether to accept it as your change does follow the RFC.

association.go Show resolved Hide resolved
@edaniels edaniels merged commit 80ec14e into pion:master Mar 6, 2024
13 checks passed
@edaniels edaniels deleted the c_w branch March 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants