Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize source port and destination port if possible #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hugoArregui
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (32ef4a1) to head (90d37b4).

Files Patch % Lines
association.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   80.77%   80.79%   +0.02%     
==========================================
  Files          49       49              
  Lines        4135     4150      +15     
==========================================
+ Hits         3340     3353      +13     
- Misses        651      653       +2     
  Partials      144      144              
Flag Coverage Δ
go 80.79% <88.23%> (+0.02%) ⬆️
wasm 67.03% <47.05%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if association is initialized with a net.Conn take the ports from there
@stv0g stv0g changed the title initialize source port and destination port if possible Initialize source port and destination port if possible Mar 1, 2024
@stv0g
Copy link
Member

stv0g commented Mar 1, 2024

I am wondering, does this break backward compatibility with existing applications which pass a net.Conn?

@hugoArregui
Copy link
Member Author

@stv0g I don't think so because I think peers are either not validating the port, or are going to validate the port correctly now. But this is me just playing with the protocol a little bit so maybe there are some cases I'm missing.

@edaniels edaniels requested a review from stv0g March 1, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants