Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test by ignoring error in stream close #330

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

MarcoPolo
Copy link
Contributor

This test was introduced in #323. Sometimes closing the stream will error with:

sending reset packet in non-established state: state=Closed

I think it's okay to ignore this error as it's not related to the test.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (3e97adc) to head (7432455).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          49       49           
  Lines        4218     4218           
=======================================
  Hits         3435     3435           
  Misses        641      641           
  Partials      142      142           
Flag Coverage Δ
go 81.43% <ø> (ø)
wasm 66.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should allow closing a stream twice. It should just be a no op.

@MarcoPolo
Copy link
Contributor Author

Agreed. This will fix the flaky test before we make that change

@MarcoPolo MarcoPolo force-pushed the marco/fix-flaky-test branch from 6c81ba0 to 7432455 Compare April 5, 2024 03:34
@MarcoPolo MarcoPolo merged commit 1be706c into master Apr 5, 2024
15 checks passed
@MarcoPolo MarcoPolo deleted the marco/fix-flaky-test branch April 5, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants