Fix inconsistencies in timer implementations #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces goroutine based ack timer with callback pattern used in other parts of the project. Adds pending timer tick counters to prevent races between Stop and timers firing. This fixes an edge case where callacks may have fired after stop was called.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 81.64% 81.58% -0.07%
==========================================
Files 51 51
Lines 3324 3323 -1
==========================================
- Hits 2714 2711 -3
- Misses 468 469 +1
- Partials 142 143 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces goroutine based ack timer with callback pattern used in other parts of the project.
Adds pending timer tick counters to prevent races between Stop and timers firing. This fixes an edge case where callacks may have fired after stop was called.