-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add congestion control parameters to config #354
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 81.24% 81.43% +0.19%
==========================================
Files 51 51
Lines 3348 4337 +989
==========================================
+ Hits 2720 3532 +812
- Misses 483 660 +177
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, is it possible to add a UT for this?
what does control look like? it would be great to see the before & after benchmarks. |
@cnderrauber fantastic! I don't fully understand the change. Would it be possible to make the diff only be related to congestion control? Like the |
What does usrsctp do here? @tuexen Do you have any opinion/any insights? What should we be doing better |
All changes and paramters are related to the congestion control, what does |
cbba1a0
to
26d88b5
Compare
The loss-based congestion control get poor performance under high bandwidth, high rtt and packet loss case since the congestion window becomes 1 mtu and increase slowly after retransmit timeout. And fast recovery retransmit cause exit slowly in consecutive packet loss. This change add paramters to the config then the user can set them to get higher throughput in such cases.
26d88b5
to
1d98af6
Compare
The loss-based congestion control get poor
performance under high bandwidth, high rtt
and packet loss case since the congestion
window becomes 1 mtu and increase slowly
after retransmit timeout. And fast recovery
retransmit cause exit slowly in consecutive
packet loss. This change add paramters to
the config then the user can set them to get
higher throughput in such cases.
Description
Reference issue
Fixes #...