-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to use ConnCtx #113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 74.47% 74.54% +0.07%
==========================================
Files 16 16
Lines 709 711 +2
==========================================
+ Hits 528 530 +2
Misses 100 100
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
09a169b
to
028acb6
Compare
on i386. Will be fixed by pion/.goassets#54 |
@at-wat mind starting |
028acb6
to
42192be
Compare
Works for me! I am somewhat hesitant to do more changes, I really want to release pion/webrtc v3. We have people building with v2 and it’s a decent support burden. |
Use Conn controlled by context.Context. If you want to use net.Conn as a underlying connection, wrapping it by github.com/pion/transport/ctxconn.ConnCtx would be the easiest way.
Read/Write is changed to be controlled by context.Context.
dbb088a
to
b1366c3
Compare
Use Conn controlled by context.Context.
If you want to use net.Conn as a underlying connection, wrapping it by github.com/pion/transport/ctxconn.ConnCtx would be the easiest way.