Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use ConnCtx #113

Merged
merged 2 commits into from
Nov 29, 2020
Merged

Migrate to use ConnCtx #113

merged 2 commits into from
Nov 29, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Nov 28, 2020

Use Conn controlled by context.Context.
If you want to use net.Conn as a underlying connection, wrapping it by github.com/pion/transport/ctxconn.ConnCtx would be the easiest way.

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #113 (b1366c3) into master (1354c92) will increase coverage by 0.07%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   74.47%   74.54%   +0.07%     
==========================================
  Files          16       16              
  Lines         709      711       +2     
==========================================
+ Hits          528      530       +2     
  Misses        100      100              
  Partials       81       81              
Flag Coverage Δ
go 74.54% <95.23%> (+0.07%) ⬆️
wasm 73.98% <85.71%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stream_srtcp.go 61.70% <80.00%> (ø)
session.go 73.46% <100.00%> (ø)
session_srtcp.go 76.19% <100.00%> (+0.28%) ⬆️
session_srtp.go 73.80% <100.00%> (+0.31%) ⬆️
stream_srtp.go 68.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1354c92...b1366c3. Read the comment docs.

@at-wat at-wat force-pushed the migrate-to-use-connctx branch from 09a169b to 028acb6 Compare November 28, 2020 14:50
@at-wat
Copy link
Member Author

at-wat commented Nov 28, 2020

failed to initialize build cache at /.cache/go-build: mkdir /.cache/go-build: permission denied
Error: Process completed with exit code 1.

on i386.
docker build -v dir -u uid creates dir as root but container is run as uid.

Will be fixed by pion/.goassets#54

go.mod Outdated Show resolved Hide resolved
Sean-Der
Sean-Der previously approved these changes Nov 29, 2020
@Sean-Der
Copy link
Member

@at-wat mind starting /v2 for this? Since we are breaking public APIs

@at-wat
Copy link
Member Author

at-wat commented Nov 29, 2020

@Sean-Der I think it's better to consider #9 before releasing v2.0.0.
Let's start v2.0.0-rc0.

@Sean-Der
Copy link
Member

Works for me! I am somewhat hesitant to do more changes, I really want to release pion/webrtc v3. We have people building with v2 and it’s a decent support burden.

Use Conn controlled by context.Context.
If you want to use net.Conn as a underlying connection,
wrapping it by github.com/pion/transport/ctxconn.ConnCtx would be the
easiest way.
Read/Write is changed to be controlled by context.Context.
@at-wat at-wat force-pushed the migrate-to-use-connctx branch from dbb088a to b1366c3 Compare November 29, 2020 03:59
@at-wat at-wat requested a review from Sean-Der November 29, 2020 06:31
@at-wat at-wat merged commit 3633bf4 into master Nov 29, 2020
@at-wat at-wat deleted the migrate-to-use-connctx branch November 29, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants