-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncordon the node #80
Open
adtandale
wants to merge
19
commits into
master
Choose a base branch
from
make_node_uncordon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
dc95c38
uncordon the node
adtandale 84ecd61
Update ocp_nodes.py
adtandale 0ef2bc1
Update ocp_nodes.py
adtandale 4c08d74
Update ocp_nodes.py
adtandale 7b19c26
Update ocp_nodes.py
adtandale 0ad3d4e
Update ocp_nodes.py
adtandale a92fbae
Update ocp_nodes.py
adtandale 1266491
Update ocp_nodes.py
adtandale 7c40dfd
Update ocp_nodes.py
adtandale e309a67
Update ocp_nodes.py
adtandale 7f5f459
Update ocp_nodes.py
adtandale 880c0cd
Update ocp_nodes.py
adtandale 09e3b0c
Update ocp_nodes.py
adtandale ef73470
Update ocp_nodes.py
adtandale 40828a7
Update ocp_nodes.py
adtandale a5590cd
Update ocp_nodes.py
adtandale 6874c63
Update test_ocp_nodes.py
adtandale 2fa9587
Update ocp_nodes.py
adtandale b3dae41
Update test_ocp_nodes.py
adtandale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's sufficient to just set 'unschedulable' to False. We should be removing the whole 'taints' element from 'spec'. We can do this by passing
"op": "remove", "path": "....
Please refer to the following:
https://stackoverflow.com/questions/27439986/what-is-the-json-patch-format-to-remove-an-element-from-an-array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I do agree, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this jsonpatch module needs to be installed explicitly using pip.