Skip to content

Commit

Permalink
Treat expired requests as list to fix indexing error (#263)
Browse files Browse the repository at this point in the history
* Treat expired requests as list to fix indexing error

* Small fix to crc-sus message when no active allocation is found

---------

Co-authored-by: Nickolas Comeau <[email protected]>
  • Loading branch information
djperrefort and Comeani authored Sep 4, 2024
1 parent cdd1626 commit 143ee47
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apps/crc_proposal_end.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def app_logic(self, args: Namespace) -> None:
if not alloc_requests:
print(f"\033[91m\033[1mNo active allocation information found in accounting system for '{args.account}'!\n")
print("Showing end date for most recently expired Resource Allocation Request:\033[0m")
alloc_requests = get_most_recent_expired_request(keystone_session, group_id)
alloc_requests = [get_most_recent_expired_request(keystone_session, group_id)]

for request in alloc_requests:
print(f"'{request['title']}' ends on {request['expire']} ")
4 changes: 2 additions & 2 deletions apps/crc_sus.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def app_logic(self, args: Namespace) -> None:

if not alloc_requests:
print(f"\033[91m\033[1mNo active allocation information found in accounting system for '{args.account}'!\n")
print("Showing end date for most recently expired Resource Allocation Request:\033[0m")
alloc_requests = get_most_recent_expired_request(keystone_session, group_id)
print("Showing remaining service unit amounts for most recently expired Resource Allocation Request:\033[0m")
alloc_requests = [get_most_recent_expired_request(keystone_session, group_id)]

per_cluster_totals = get_per_cluster_totals(keystone_session, alloc_requests,
get_enabled_cluster_ids(keystone_session))
Expand Down
2 changes: 1 addition & 1 deletion apps/crc_usage.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def app_logic(self, args: Namespace) -> None:
if not alloc_requests:
print(f"\033[91m\033[1mNo active allocation information found in accounting system for '{args.account}'!\n")
print("Showing usage information for most recently expired Resource Allocation Request: \033[0m")
alloc_requests = get_most_recent_expired_request(keystone_session, group_id)
alloc_requests = [get_most_recent_expired_request(keystone_session, group_id)]

clusters = get_enabled_cluster_ids(keystone_session)

Expand Down

0 comments on commit 143ee47

Please sign in to comment.