Use search and order params in keystone utility functions #275
Conversation
…f searching on the slurm account name
There was a problem hiding this comment.
Using search to filter requests by the team name is clever. I hadn't thought to mix the search and filter functionality in that way.
I'm a little concerned a user may inadvertently be returned requests from a different account than the one specified. The search includes things like the request title and description, so what happens if an account name is mentioned in one of these fields by a different team? I doubt this would be intentional, but it could happen if an account has a common name (e.g., smith) and the other team's description references a publication by the author. This is just a silly example to clarify a point.
General users wouldn't be effected much since they would have to be a member of the other accounts. However, this becomes more problematic for admins.
Interested to hear your thoughts.
This PR makes the wrappers leverage the search and order params introduced in Better-HPC/keystone-python-client#65