Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Document New Excludes Preference #181

Merged
merged 1 commit into from
Jul 10, 2024
Merged

📝 Document New Excludes Preference #181

merged 1 commit into from
Jul 10, 2024

Conversation

ryandens
Copy link
Member

@ryandens ryandens commented Jul 1, 2024 •
edited by gilday
Loading

/close #work

@ryandens ryandens requested review from dunningdan and bdoyal July 1, 2024 19:38
@ryandens ryandens force-pushed the ryandens/ISS-1494 branch from dfb82c9 to 17dae7d Compare July 1, 2024 19:40
bdoyal
bdoyal approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@bdoyal bdoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the paths have to be full paths and the root be the root of a repository or will it also respect wildcard or glob patterns?

In either case, it would be good to mention more details here.

@gilday gilday force-pushed the ryandens/ISS-1494 branch from 17dae7d to 1e85dcc Compare July 8, 2024 16:08
@gilday gilday changed the title 📝 add documentation for new exclusions preference 📝 Document New Excludes Preference Jul 8, 2024
@gilday gilday changed the title 📝 Document New Excludes Preference 📝 Document New Excludes Preference Jul 8, 2024
@gilday gilday force-pushed the ryandens/ISS-1494 branch 3 times, most recently from 1432b1d to 55ef984 Compare July 10, 2024 13:24
@gilday gilday force-pushed the ryandens/ISS-1494 branch from 55ef984 to a982675 Compare July 10, 2024 13:28
@gilday gilday merged commit ee802bb into main Jul 10, 2024
3 checks passed
@gilday gilday deleted the ryandens/ISS-1494 branch July 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdoyal bdoyal bdoyal approved these changes

@dunningdan dunningdan dunningdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryandens @dunningdan @bdoyal @gilday