Feature/landing page #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terranosaurus
requested changes
Aug 31, 2023
There was a problem hiding this comment.
This looks great! A few things:
- The title is using "Poppins-thin" as the font family, but this changes the appearance considerably. In general, I don't like the way this is rendering so let's do Poppins, 64px at font-weight: 700 instead please (matches our website title)
- The tile for "FAQs" has a typo and is displaying as "AQs"
- The installation tile is linking to the introduction page, not the installation page
- The "GitHub App page" link (please capitalize the "H") in the first tile should link to that page in a new window. See annotation 2 in Figma
- The "codemodder project" link in the second tile should link to codemodder.io in a new window
- The "Java" and "Python" links in the second tile should link directly to those pages (https://docs.pixee.ai/category/java etc.)
- The light mode link color should be changed to #C10B5E
|
Looks great, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.