Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

Keyboard shortcuts #755

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

treppo
Copy link
Contributor

@treppo treppo commented Jul 25, 2016

Opening this pull–request to track work on #25

so far implemented:

  • Previous mail on the list/move up: Up or "k"
  • Next mail on the list/move down: Down or "j"
  • Check current email's checkbox: x
  • Close open email: Esc
  • Send: Command/Control + Enter
  • Compose: c
  • Focus on search input: / or "s"
  • Tag email (open "new tag" input): t
  • Open keyboard shortcuts map: ?
  • Reply: r
  • Reply to all: a
  • Forward: f
  • Delete: #

}

function composeBoxIsShown() {
return $('#' + composeBoxId).length;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very happy with this. Is there any way to get that state of the application other than by accessing the DOM?

Copy link
Member

@bwagnerr bwagnerr Aug 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treppo Not really, we just try to minimize the impact of messing with the dom by only changing things rendered inside the specific component. In this case, I would use the key combos to trigger events to specific components, that can deal with the dom manipulation it needs to do the action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwagnerr i do trigger events on the specific components. only these events here have to be triggered on document. and therefore i have to check whether the compose box is open by accessing the dom…

@treppo treppo force-pushed the keyboard-shortcuts branch from dd08974 to 7a50d7d Compare July 25, 2016 10:26
@treppo treppo force-pushed the keyboard-shortcuts branch 2 times, most recently from ec1e675 to eb9ce7e Compare July 25, 2016 14:05
@deniscostadsc deniscostadsc self-assigned this Jul 28, 2016
@deniscostadsc deniscostadsc removed their assignment Aug 15, 2016
@re-nobre re-nobre added the PR label Sep 26, 2016
@anikarni anikarni removed the PR label May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants