Spelling #341
Spelling #341
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
| @@ -7,7 +7,7 @@ Devel::Cover history | |||
| - Test with DBM::Deep on CI | |||
|
|
|||
| 1.43 - 8 June 2024 | |||
| - Bump coancover version requirements to 5.38 | |||
| - Bump cpancover version requirements to 5.38 | |||
| @@ -75,7 +75,7 @@ Devel::Cover history | |||
|
|
|||
| 1.32 - 25 April 2019 | |||
| - Test up to 5.26.3, 5.28.3 and 5.29.10 | |||
| - Get dev environment working on MacOS | |||
| - Get dev environment working on macOS | |||
| @@ -246,15 +246,15 @@ Devel::Cover history | |||
| - Add DEVEL_COVER_NO_TESTS option to not run any tests during p5cover | |||
|
|
|||
| 1.04 - 1 June 2013 | |||
| - Fix return code from cover (Kan Fushihara) (guthub 61) | |||
| - Fix return code from cover (Kan Fushihara) (GH-61) | |||
There was a problem hiding this comment.
brand, but for consistency, let's use the abbreviation
| * http://www.pjcj.net | ||
| * https://pjcj.net |
There was a problem hiding this comment.
both domains were used in this repository. Everything redirects to the shorter domain w/ https, so unless there's a specific reason to use http: or the longer www, let's use the one following the redirect.
| @@ -570,16 +570,16 @@ $Templates{summary} = <<'EOT'; | |||
| <script type="text/javascript"> | |||
| <!-- hide | |||
| function filter_files(filter_by) { | |||
| var allelements = document.getElementsByTagName("tr"); | |||
| var allElements = document.getElementsByTagName("tr"); | |||
There was a problem hiding this comment.
this isn't technically a spelling thing, but makes it easier to catch misspelled words...
| my $dfil = $db->cover->file($file); | ||
| my $subs = $dfil->subroutine or return; | ||
| my $pods = $options->{show}{pod} && $dfil->pod; | ||
| my $dfile = $db->cover->file($file); |
There was a problem hiding this comment.
both $dfil and $dfile were used, and afaict they mean the same thing...
| @@ -335,7 +335,7 @@ displayed. Correctly covered criteria are shown in green. Incorrectly | |||
| covered criteria are shown in red. Any incorrectly covered criterion will | |||
| override a correctly covered criterion. | |||
|
|
|||
| If the coverage for the file being displayed is out of date the a function | |||
| If the coverage for the file being displayed is out of date the function | |||
There was a problem hiding this comment.
this is a recent catch -- not technically a spelling error, but as check-spelling has to parse each line, it might as well complain.
| @@ -466,7 +466,7 @@ Devel::Cover history | |||
| - Fix gcov2perl to work with large numbers (Thomas Dorner) (RT-45028) | |||
| - Fix "gcov -l" include files (Thomas Dorner) (RT-44864) | |||
| - Test against 5.12.1 | |||
| - Gross workaround for for regexp evals (Florian Ragwitz) | |||
| - Gross workaround for regexp evals (Florian Ragwitz) | |||
There was a problem hiding this comment.
another not precisely spelling fix, but spell checking has handled this for decades.
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
Thanks for this. I think most of the changes are good, but I'll push back a little on the cxt/ctx change. This is a personal preference until more people work on that code. I'll need to go though all the changes in a bit more detail before I merge though. |
|
I'm assuming you'll drop/rewrite/squash the commits as applicable. I probably won't have much time to touch things for the next ~2 weeks. |
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/Devel--Cover/actions/runs/9962716171#summary-27527119207
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/Devel--Cover/actions/runs/9962716545#summary-27527123604